Never seen a forex book I thought was any good. There don't seem to be that many of them about. Seems to be mostly because the majority of these books are written by Americans they are all in love with the stock futures markets. If anyone has a GOOD forex book I'd love to take a look.
For more general trading I would highly reccommend New Market Wizards ( the original Market Wizards to a slightly lesser extent).
There seem to be a few common threads running through the careers of the vast majority of the good traders interviwed in these books;
1) The majority didn't make it straight away. They blew up usually AT LEAST once but learned their mistakes.
2) When successful they emphasised the good money management was at least as successful as a good system. Most of the time when they initially failed it was this aspect of their approach that let them down.
3) They all ended up with styles that suited their personailties lifestyle.
4) They were either blessed with or learned the humility to admit when they were wrong walk away a trade. They discarded their egos learned to manage the fear greed that blight the majority of traders at least some of the time.
It all sounds so easy when you write it down like that :-)